Discussion:
[mosh-devel] Mosh 1.3.1 release candidate 2 available for testing
john hood
2017-05-22 01:20:46 UTC
Permalink
Hi all,

I'm pleased to announce a release candidate for Mosh 1.3.1. This is a minor, bug-fix release, addressing platform/portability issues and a couple of terminal emulation issues. Most users will not need to upgrade to this release, but if you use the JuiceSSH Android client or tmux 2.4 on your server, there are fixes here for you.

The Changelog for this release:

* Platform support:
* Restore perl 5.8.8 support for RHEL5. (Alexander Chernyakhovsky)
* Make tests detect UTF-8 locale with a helper executable. (John Hood)
* Don't print /etc/motd on IllumOS. (John Hood)
* Print {,/var}/run/motd.dynamic on Ubuntu. (John Hood)
* Fix build on Haiku. (Adrien Destugues)
* Disable unicode-later-combining.test for tmux 2.4.
This fixes build failures. (John Hood)

* Bug fixes:
* Work around JuiceSSH rendering bug. (John Hood)
* Do not move cursor for SCROLL UP and SCROLL DOWN--
fixes an issue with tmux 2.4. (John Hood)

Source code is available in an unofficial distribution tarball at
<https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.1-rc2/mosh-1.3.1-rc2.tar.gz>
(SHA256 sum
182410c7c063347c04610ee1c83f394534ac41680b5a0352fa3e4d8eab49179a).
Please note that the official signed distribution tarball will probably
be hosted at <https://mosh.org>; do not use GitHub releases as the
canonical source for Mosh.

There is also an unofficial OS X package build at
<https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.1-rc2/mosh-1.3.1-rc2.pkg>
(SHA256 sum
ead87f7ce6477361a99593a1cc5400acf3456826aad9bf6fcb517b72964b07ce) and
accompanying build report at
<https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.1-rc2/mosh-1.3.1-rc2-osx-build-report.tbz>.
Also see the Travis build logs at
<https://travis-ci.org/mobile-shell/mosh/builds/234652666>. The package
supports OS X 10.10 or later.

(If you are using a package system such as MacPorts or Homebrew, I
recommend using that, though.)

As always, Ubuntu PPA builds of the latest source are available at
ppa:keithw/mosh.

Notes to packagers:

* Previous versions of Mosh have difficulty running tests with tmux 2.4. These issues should be worked-around for 2.4, and resolved with a fix in later versions of tmux.

Areas we'd like to see testing ('make distcheck', mostly) in before we
do a final release:

* RHEL 5 and 6
* OpenBSD
* Haiku
* Solaris
* Use with the JuiceSSH Android client
* Any system with tmux 2.4 or later version installed

Your testing is very unlikely to prove Mosh to be free of bugs, but your
testing will help us make 1.3.1 a better release. Please report any
issues you find on Github; we can be found on IRC at
<irc://irc.freenode.net/mosh>.

I hope to make the next Mosh release more feature oriented, bringing
significant new functionality. SSH agent forwarding is still high on
the list.

The Mosh team thanks you for your help.

--John Hood
Richard Woodbury
2017-05-26 21:49:22 UTC
Permalink
-mosh-users

Passes smoke test in Mosh for Chrome, although my build system isn't
running any tests.
Post by john hood
Hi all,
I'm pleased to announce a release candidate for Mosh 1.3.1. This is a minor, bug-fix release, addressing platform/portability issues and a couple of terminal emulation issues. Most users will not need to upgrade to this release, but if you use the JuiceSSH Android client or tmux 2.4 on your server, there are fixes here for you.
* Restore perl 5.8.8 support for RHEL5. (Alexander Chernyakhovsky)
* Make tests detect UTF-8 locale with a helper executable. (John Hood)
* Don't print /etc/motd on IllumOS. (John Hood)
* Print {,/var}/run/motd.dynamic on Ubuntu. (John Hood)
* Fix build on Haiku. (Adrien Destugues)
* Disable unicode-later-combining.test for tmux 2.4.
This fixes build failures. (John Hood)
* Work around JuiceSSH rendering bug. (John Hood)
* Do not move cursor for SCROLL UP and SCROLL DOWN--
fixes an issue with tmux 2.4. (John Hood)
Source code is available in an unofficial distribution tarball at<https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.1-rc2/mosh-1.3.1-rc2.tar.gz> <https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.0-rc2/mosh-1.3.0-rc2.tar.gz>
(SHA256 sum
182410c7c063347c04610ee1c83f394534ac41680b5a0352fa3e4d8eab49179a).
Please note that the official signed distribution tarball will probably
be hosted at <https://mosh.org> <https://mosh.org>; do not use GitHub releases as the
canonical source for Mosh.
There is also an unofficial OS X package build at<https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.1-rc2/mosh-1.3.1-rc2.pkg> <https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.0-rc2/mosh-1.3.0-rc2.pkg>
(SHA256 sumead87f7ce6477361a99593a1cc5400acf3456826aad9bf6fcb517b72964b07ce) and
accompanying build report at<https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.1-rc2/mosh-1.3.1-rc2-osx-build-report.tbz> <https://github.com/mobile-shell/mosh/releases/download/mosh-1.3.0-rc2/mosh-1.3.0-rc2-osx-build-report.tbz>.
Also see the Travis build logs at<https://travis-ci.org/mobile-shell/mosh/builds/234652666> <https://travis-ci.org/mobile-shell/mosh/builds/189390973>. The package
supports OS X 10.10 or later.
(If you are using a package system such as MacPorts or Homebrew, I
recommend using that, though.)
As always, Ubuntu PPA builds of the latest source are available at
ppa:keithw/mosh.
* Previous versions of Mosh have difficulty running tests with tmux 2.4. These issues should be worked-around for 2.4, and resolved with a fix in later versions of tmux.
Areas we'd like to see testing ('make distcheck', mostly) in before we
* RHEL 5 and 6
* OpenBSD
* Haiku
* Solaris
* Use with the JuiceSSH Android client
* Any system with tmux 2.4 or later version installed
Your testing is very unlikely to prove Mosh to be free of bugs, but your
testing will help us make 1.3.1 a better release. Please report any
issues you find on Github; we can be found on IRC at<irc://irc.freenode.net/mosh>.
I hope to make the next Mosh release more feature oriented, bringing
significant new functionality. SSH agent forwarding is still high on
the list.
The Mosh team thanks you for your help.
--John Hood
_______________________________________________
mosh-users mailing list
http://mailman.mit.edu/mailman/listinfo/mosh-users
Jeremie Courreges-Anglas
2017-05-26 23:55:36 UTC
Permalink
On OpenBSD-current (amd64), make check reports two failures. Log files
attached.
Keith Winstein
2017-05-27 00:02:06 UTC
Permalink
Thanks, Jeremie! Do these tests work with 1.3.0? (And if so, are you able
to bisect this for us?)

Cheers,
Keith
Post by Jeremie Courreges-Anglas
On OpenBSD-current (amd64), make check reports two failures. Log files
attached.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
_______________________________________________
mosh-users mailing list
http://mailman.mit.edu/mailman/listinfo/mosh-users
Jeremie Courreges-Anglas
2017-05-27 01:21:48 UTC
Permalink
Post by Keith Winstein
Thanks, Jeremie! Do these tests work with 1.3.0? (And if so, are you able
to bisect this for us?)
Summary:
emulation-80th-column.test result: ERROR instead of FAIL
emulation-scroll.test result: did not exist in 1.3.0

So nothing to bisect, as far as I can see. Log files for 1.3.0
attached, let me know if you need more information.

PS: these test results after applying a few changes to the test
infrastructure. The changes, related to tmux(1) and locale(1), are
included in mosh-1.3.1-rc2.
John Hood
2017-05-27 01:37:30 UTC
Permalink
Post by Jeremie Courreges-Anglas
Post by Keith Winstein
Thanks, Jeremie! Do these tests work with 1.3.0? (And if so, are you able
to bisect this for us?)
emulation-80th-column.test result: ERROR instead of FAIL
emulation-scroll.test result: did not exist in 1.3.0
So nothing to bisect, as far as I can see. Log files for 1.3.0
attached, let me know if you need more information.
OpenBSD-current, of course, has a prerelease version of tmux.

Does mosh-1.3.1rc2 build successfully for you with OpenBSD 6.1?

I took a quick look at this. I was able to reproduce the
emulation-scroll.test failure in tmux 2.4 on FreeBSD 11.0 in tmux
without mosh, which points both to an issue in tmux, and also to
insufficient testing of the tests on my part :)

I'll examine this a little more closely with the portable tmux soon.

regards,

--jh
Jeremie Courreges-Anglas
2017-05-28 15:15:29 UTC
Permalink
Hi,

I did not look precisely at problems reported by make check with
mosh-1.3.1-rc2 on OpenBSD-current; but here are the logs for ten make
check runs:

http://autogeree.net/~jca/tmp/mosh-1.3.1-rc2-OpenBSD-make-check.tgz

grep ERROR: shows that emulation-80th-column exists with either FAIL or
ERROR.
Post by John Hood
Post by Jeremie Courreges-Anglas
Post by Keith Winstein
Thanks, Jeremie! Do these tests work with 1.3.0? (And if so, are you able
to bisect this for us?)
emulation-80th-column.test result: ERROR instead of FAIL
emulation-scroll.test result: did not exist in 1.3.0
So nothing to bisect, as far as I can see. Log files for 1.3.0
attached, let me know if you need more information.
OpenBSD-current, of course, has a prerelease version of tmux.
That's quite possible, but I don't know how the tmux changes in OpenBSD
and the tmux portable releases are related.
Post by John Hood
Does mosh-1.3.1rc2 build successfully for you with OpenBSD 6.1?
Yup.
Post by John Hood
I took a quick look at this. I was able to reproduce the
emulation-scroll.test failure in tmux 2.4 on FreeBSD 11.0 in tmux
without mosh, which points both to an issue in tmux, and also to
insufficient testing of the tests on my part :)
I'll examine this a little more closely with the portable tmux soon.
ack, let me know if you need more data.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
john hood
2017-05-28 20:03:40 UTC
Permalink
Post by Jeremie Courreges-Anglas
ack, let me know if you need more data.
Nicholas Marriott and I seem to have found a solution involving small
changes to both tmux and mosh's tests. I'm waiting for his changes to
appear in OpenBSD CVS and/or on GitHub for final verification.

regards,

--jh
Jeremie Courreges-Anglas
2017-05-28 23:31:39 UTC
Permalink
Post by john hood
Post by Jeremie Courreges-Anglas
ack, let me know if you need more data.
Nicholas Marriott and I seem to have found a solution involving small
changes to both tmux and mosh's tests. I'm waiting for his changes to
appear in OpenBSD CVS and/or on GitHub for final verification.
With Nicholas' last two commits to tmux:

https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/tmux/cmd-refresh-client.c.diff?r1=1.25&r2=1.26&f=h
https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/tmux/cmd-new-session.c.diff?r1=1.106&r2=1.107&f=h

tests look fine here:

...
make check-TESTS
PASS: ocb-aes
PASS: encrypt-decrypt
PASS: base64
PASS: nonce-incr
PASS: local.test
PASS: e2e-success.test
XFAIL: e2e-failure.test
PASS: emulation-ascii-iso-8859.test
PASS: emulation-80th-column.test
PASS: emulation-attributes-vt100.test
PASS: emulation-attributes-16color.test
XFAIL: emulation-attributes-256color8.test
PASS: emulation-attributes-256color248.test
PASS: emulation-back-tab.test
PASS: emulation-cursor-motion.test
PASS: emulation-multiline-scroll.test
PASS: emulation-scroll.test
PASS: emulation-wrap-across-frames.test
PASS: network-no-diff.test
PASS: prediction-unicode.test
PASS: pty-deadlock.test
PASS: repeat.test
PASS: repeat-with-input.test
PASS: server-network-timeout.test
PASS: server-signal-timeout.test
PASS: window-resize.test
PASS: unicode-combine-fallback-assert.test
PASS: unicode-later-combining.test
============================================================================
Testsuite summary for mosh 1.3.1-rc2
============================================================================
# TOTAL: 29
# PASS: 27
# SKIP: 0
# XFAIL: 2
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
john hood
2017-06-04 21:27:52 UTC
Permalink
Nicholas,

Could you test again on OpenBSD-current and mosh master? I fully expect
that to work but some verification would be good.

regards,

--jh
Post by Jeremie Courreges-Anglas
Post by john hood
Post by Jeremie Courreges-Anglas
ack, let me know if you need more data.
Nicholas Marriott and I seem to have found a solution involving small
changes to both tmux and mosh's tests. I'm waiting for his changes to
appear in OpenBSD CVS and/or on GitHub for final verification.
https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/tmux/cmd-refresh-client.c.diff?r1=1.25&r2=1.26&f=h
https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/tmux/cmd-new-session.c.diff?r1=1.106&r2=1.107&f=h
...
make check-TESTS
PASS: ocb-aes
PASS: encrypt-decrypt
PASS: base64
PASS: nonce-incr
PASS: local.test
PASS: e2e-success.test
XFAIL: e2e-failure.test
PASS: emulation-ascii-iso-8859.test
PASS: emulation-80th-column.test
PASS: emulation-attributes-vt100.test
PASS: emulation-attributes-16color.test
XFAIL: emulation-attributes-256color8.test
PASS: emulation-attributes-256color248.test
PASS: emulation-back-tab.test
PASS: emulation-cursor-motion.test
PASS: emulation-multiline-scroll.test
PASS: emulation-scroll.test
PASS: emulation-wrap-across-frames.test
PASS: network-no-diff.test
PASS: prediction-unicode.test
PASS: pty-deadlock.test
PASS: repeat.test
PASS: repeat-with-input.test
PASS: server-network-timeout.test
PASS: server-signal-timeout.test
PASS: window-resize.test
PASS: unicode-combine-fallback-assert.test
PASS: unicode-later-combining.test
============================================================================
Testsuite summary for mosh 1.3.1-rc2
============================================================================
# TOTAL: 29
# PASS: 27
# SKIP: 0
# XFAIL: 2
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
_______________________________________________
mosh-devel mailing list
http://mailman.mit.edu/mailman/listinfo/mosh-devel
john hood
2017-05-28 17:32:37 UTC
Permalink
Post by John Hood
Post by Jeremie Courreges-Anglas
Post by Keith Winstein
Thanks, Jeremie! Do these tests work with 1.3.0? (And if so, are you able
to bisect this for us?)
emulation-80th-column.test result: ERROR instead of FAIL
emulation-scroll.test result: did not exist in 1.3.0
So nothing to bisect, as far as I can see. Log files for 1.3.0
attached, let me know if you need more information.
OpenBSD-current, of course, has a prerelease version of tmux.
Does mosh-1.3.1rc2 build successfully for you with OpenBSD 6.1?
I took a quick look at this. I was able to reproduce the
emulation-scroll.test failure in tmux 2.4 on FreeBSD 11.0 in tmux
without mosh, which points both to an issue in tmux, and also to
insufficient testing of the tests on my part :)
I'll examine this a little more closely with the portable tmux soon.
emulation-scroll.test fails when run directly with tmux because tmux
doesn't implement SCROLL DOWN in its terminal emulator, so that's not
actually the issue. (I'm not sure tmux implements SCROLL UP correctly
though.)

The real issue is that tmux from git master (and presumably
OpenBSD-current), when used in control master mode, now creates an 80x23
terminal pane, rather than the 80x24 pane that it did in previous
versions. Those two tests rely on the height of the screen window.

Newer versions of tmux do offer a 'refresh-client -C 80,24' command that
can handle this but integrating that into the test framework is
unfortunately tricky. It also doesn't seem to work in current versions
of tmux, the terminal pane remains at 23 lines even after running this
command. I've opened <https://github.com/tmux/tmux/issues/947> for this
issue.

I'm half inclined to call this "not a release blocker", but half the
reason for this release is to deal with tmux issues in the first place :)

regards,

--jh
Loading...